-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in CCE degradation and add HGCal to aging customizations #19896
Conversation
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @lgray (Lindsey Gray) for master. It involves the following packages: DataFormats/HGCDigi @cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
return process | ||
|
||
def customise_aging_3000_ultimate(process): | ||
process=ageHcal(process,3000,7.5e34,"ultimate") | ||
process=ageEcal(process,3000,7.5e34) | ||
process=agedHGCal(process) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the aging model doesn't depend at all on the luminosity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lgray still curious about this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I only have two data points and no indication of how they scale, if there's saturation of any effects, etc.
@lgray is there an example of how the aging affects physics distributions? (e.g. jet response) |
Comparison is ready Comparison Summary:
|
@kpedro88 Nominally it should cause an increase in photon/jet energy
resolution, once the rechits are recalibrated to adjust for the change in
scale. There may be some minor change in the jet energy scale as well,
depending on how the thresholds are managed.
I'll add the corresponding change to the rechit energy scale so that this
will hold true. Update in a moment.
…On Tue, Jul 25, 2017 at 4:24 PM, cmsbuild ***@***.***> wrote:
Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-
request-integration/PR-19896/21731/summary.html
Comparison Summary:
- No significant changes to the logs found
- Reco comparison results: 0 differences found in the comparisons
- DQMHistoTests: Total files compared: 23
- DQMHistoTests: Total histograms compared: 2355459
- DQMHistoTests: Total failures: 29997
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 2325296
- DQMHistoTests: Total skipped: 166
- DQMHistoTests: Total Missing objects: 0
- Checked 93 log files, 14 edm output root files, 23 DQM output files
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19896 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABBMOSbuY1xxHZxvp3J6CP2Oyc2X4KNaks5sRl0cgaJpZM4Oida2>
.
|
Pull request #19896 was updated. @perrotta, @civanch, @mdhildreth, @cmsbuild, @kpedro88, @slava77, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
+code-checks |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@civanch @mdhildreth please sign |
merge |
This PR implements the charge collection efficiency degradation expected after irradiation of silicon.
The the deposited charged is now degraded in addition to the increase in the electronics noise.
There is an option to follow the value of the MIP (which changes as the CCE degrades) with the thresholds for the digitizer. Presently it is set to false.
This PR also fixes an issue with saturation where saturated rechits were reading as zero energy.